Skip to content

Bump the all group in /web/vtadmin with 8 updates#19615

Merged
timvaillancourt merged 6 commits into
mainfrom
dependabot/npm_and_yarn/web/vtadmin/all-2ab2934841
Mar 11, 2026
Merged

Bump the all group in /web/vtadmin with 8 updates#19615
timvaillancourt merged 6 commits into
mainfrom
dependabot/npm_and_yarn/web/vtadmin/all-2ab2934841

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Mar 10, 2026 •
edited by timvaillancourt
Loading

Copy link
Copy Markdown
Contributor

Bumps the all group in /web/vtadmin with 8 updates:

Package From To Notes
protobufjs 7.5.4 8.0.0 Reverted — protobufjs-cli@2.0.0 requires protobufjs@^7.0.0
react-router-dom 5.3.4 7.13.1 Migrated — Switch→Routes, useHistory→useNavigate, useRouteMatch removed, tests updated
@rollup/plugin-commonjs 29.0.0 29.0.2 Patch bump, no migration needed
@types/node 25.3.3 25.4.0 Minor bump, no migration needed
eslint 8.57.1 10.0.3 Reverted — eslint-config-react-app@7.0.1 requires eslint@^8.0.0
stylelint 16.26.1 17.4.0 Migrated — removed unknown rule, fixed deprecated CSS properties
stylelint-config-standard-scss 13.1.0 17.0.0 Migrated — paired with stylelint v17
tailwindcss 3.4.19 4.2.1 Migrated — new @tailwindcss/postcss plugin, @import/@config directives, @reference in SCSS modules

@dependabot
Bump the all group in /web/vtadmin with 8 updates
40fd2ef 
Bumps the all group in /web/vtadmin with 8 updates:

| Package | From | To |
| --- | --- | --- |
| [protobufjs](https://github.com/protobufjs/protobuf.js) | `7.5.4` | `8.0.0` |
| [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) | `5.3.4` | `7.13.1` |
| [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) | `29.0.0` | `29.0.2` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `25.3.3` | `25.4.0` |
| [eslint](https://github.com/eslint/eslint) | `8.57.1` | `10.0.3` |
| [stylelint](https://github.com/stylelint/stylelint) | `16.26.1` | `17.4.0` |
| [stylelint-config-standard-scss](https://github.com/stylelint-scss/stylelint-config-standard-scss) | `13.1.0` | `17.0.0` |
| [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss) | `3.4.19` | `4.2.1` |


Updates `protobufjs` from 7.5.4 to 8.0.0
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@protobufjs-v7.5.4...protobufjs-v8.0.0)

Updates `react-router-dom` from 5.3.4 to 7.13.1
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@7.13.1/packages/react-router-dom)

Updates `@rollup/plugin-commonjs` from 29.0.0 to 29.0.2
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v29.0.2/packages/commonjs)

Updates `@types/node` from 25.3.3 to 25.4.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `eslint` from 8.57.1 to 10.0.3
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v8.57.1...v10.0.3)

Updates `stylelint` from 16.26.1 to 17.4.0
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@16.26.1...17.4.0)

Updates `stylelint-config-standard-scss` from 13.1.0 to 17.0.0
- [Release notes](https://github.com/stylelint-scss/stylelint-config-standard-scss/releases)
- [Changelog](https://github.com/stylelint-scss/stylelint-config-standard-scss/blob/main/CHANGELOG.md)
- [Commits](stylelint-scss/stylelint-config-standard-scss@v13.1.0...v17.0.0)

Updates `tailwindcss` from 3.4.19 to 4.2.1
- [Release notes](https://github.com/tailwindlabs/tailwindcss/releases)
- [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.2.1/packages/tailwindcss)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-version: 8.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: react-router-dom
  dependency-version: 7.13.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: "@rollup/plugin-commonjs"
  dependency-version: 29.0.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: "@types/node"
  dependency-version: 25.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: eslint
  dependency-version: 10.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: stylelint
  dependency-version: 17.4.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: stylelint-config-standard-scss
  dependency-version: 17.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: tailwindcss
  dependency-version: 4.2.1
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 10, 2026
@dependabot dependabot Bot requested a review from beingnoble03 as a code owner March 10, 2026 20:44
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 10, 2026
@github-actions github-actions Bot added this to the v24.0.0 milestone Mar 10, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 10, 2026
@vitess-bot

vitess-bot Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions Bot added Component: VTAdmin VTadmin interface Type: Dependencies Dependency updates labels Mar 10, 2026
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 10, 2026
@timvaillancourt timvaillancourt self-assigned this Mar 11, 2026
@timvaillancourt timvaillancourt enabled auto-merge (squash) March 11, 2026 15:43
@timvaillancourt @claude
Revert eslint and protobufjs major bumps due to peer dependency confl…
7cca27e 
…icts

eslint v10 conflicts with eslint-config-react-app@7 (requires eslint@^8).
protobufjs v8 conflicts with protobufjs-cli@2 (requires protobufjs@^7).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt and others added 4 commits March 11, 2026 17:09
@timvaillancourt @claude
Migrate tailwindcss v4, react-router-dom v7, and stylelint v17
9d831ae 
Fixes CI failures from the dependabot dependency bumps by performing
the necessary migrations for the three major version upgrades:

- tailwindcss v3→v4: use @tailwindcss/postcss plugin, @import/@config
  directives, @reference in SCSS modules, v4 !important syntax
- react-router-dom v5→v7: Switch→Routes, Redirect→Navigate,
  useHistory→useNavigate, useRouteMatch removed (relative paths),
  activeClassName→className callback, test migration to MemoryRouter
- stylelint v15→v17: remove unknown rule, grid-gap→gap,
  rgba→rgb modern notation, appearance:button→auto

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt @claude
Fix prettier formatting and CreateKeyspace test race condition
db31aa9 
Apply prettier formatting to 6 files and wrap disabled button
assertion in waitFor to fix flaky test timing issue.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt @claude
Fix eslint no-wait-for-multiple-assertions violation
36846dc 
Split multiple assertions in waitFor into separate blocks to
satisfy testing-library/no-wait-for-multiple-assertions rule.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt @claude
Fix CreateKeyspace test: keep assertions atomic in waitFor
7534fbe 
The disabled attribute check must be inside waitFor alongside the text
content check, as both assert transient loading state that can resolve
before a separate assertion runs. Suppress the eslint rule inline since
the multiple assertions are intentionally coupled.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
mattlord
mattlord approved these changes Mar 11, 2026
View reviewed changes

@mattlord mattlord left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for when the tests pass :-))

@timvaillancourt timvaillancourt merged commit 6982387 into main Mar 11, 2026
172 of 173 checks passed
@timvaillancourt timvaillancourt deleted the dependabot/npm_and_yarn/web/vtadmin/all-2ab2934841 branch March 11, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber

@mhamza15 mhamza15 Awaiting requested review from mhamza15

Assignees

@timvaillancourt timvaillancourt

Labels

Component: VTAdmin VTadmin interface dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code Type: Dependencies Dependency updates

Projects

None yet

Milestone

v24.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mattlord @timvaillancourt