Skip to content

Consolidate CI test workflows#19259

Merged
mhamza15 merged 8 commits into
vitessio:mainfrom
mhamza15:ci
Feb 4, 2026
Merged

Consolidate CI test workflows#19259
mhamza15 merged 8 commits into
vitessio:mainfrom
mhamza15:ci

Conversation

@mhamza15

@mhamza15 mhamza15 commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Consolidates the unit test and end to end CI workflows. For unit tests, a new single unit_test.yml contains a matrix of all the combinations of tests to run. For end to end tests, the new single cluster_endtoend.yml workflow reads test/config.json and dynamically generates a matrix from all the shards. Then each job runs for a shard, reads what dependencies it might need (xtrabackup, larger runner, etc.), performs the appropriate steps, and runs the tests.

The only remaining workflow that was auto-generated is vitess_tester_vtgate.yml. As it's entirely static, we can create a normal workflow file, and remove the generation code and the test templates entirely.

The job names are the same, so the required checks should apply as normal.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Consolidates the end to end CI workflows. The new single
`cluster_endtoend.yml` workflow reads `test/config.json` and generates a
matrix from all the shards. Then each job runs for a shard, reads what
dependencies it might need (xtrabackup, larger runner, etc.), performs
the appropriate steps, and runs the tests.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@mhamza15 mhamza15 self-assigned this Feb 2, 2026
@github-actions github-actions Bot added this to the v24.0.0 milestone Feb 2, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 2, 2026
@vitess-bot

vitess-bot Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mhamza15 mhamza15 added Component: Build/CI Type: CI/Build Backport to: release-22.0 Backport to: release-23.0 Needs to be backport to release-23.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 2, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@mhamza15 mhamza15 changed the title Consolidate end to end CI workflows Consolidate CI test workflows Feb 2, 2026
@codecov

codecov Bot commented Feb 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.94%. Comparing base (055cef1) to head (a442ba3).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19259      +/-   ##
==========================================
- Coverage   69.95%   69.94%   -0.01%     
==========================================
  Files        1610     1610              
  Lines      215901   215901              
==========================================
- Hits       151025   151020       -5     
- Misses      64876    64881       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@mhamza15 mhamza15 marked this pull request as ready for review February 2, 2026 18:45
@mhamza15 mhamza15 merged commit 645c38d into vitessio:main Feb 4, 2026
104 checks passed
@mhamza15 mhamza15 deleted the ci branch February 4, 2026 01:05
mhamza15 added a commit to mhamza15/vitess that referenced this pull request Feb 4, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15 added a commit that referenced this pull request Feb 4, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15 added a commit to mhamza15/vitess that referenced this pull request Feb 4, 2026
Fixes the go upgrade tool by removing the `test/templates` directory
from the list of directories/files to update. Those test templates were
removed when the workflows were consolidated into one in
vitessio#19259.
@mhamza15 mhamza15 mentioned this pull request Feb 4, 2026
5 tasks
mhamza15 added a commit to mhamza15/vitess that referenced this pull request Feb 4, 2026
Fixes the go upgrade tool by removing the `test/templates` directory
from the list of directories/files to update. Those test templates were
removed when the workflows were consolidated into one in
vitessio#19259.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15 added a commit that referenced this pull request Feb 4, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15 added a commit that referenced this pull request Feb 5, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15 added a commit that referenced this pull request Feb 5, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants