Add test coverage for dropTargetShards function #19086
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit test coverage for the
dropTargetShardsfunction intraffic_switcher.go, which previously had 0% test coverage.Adds
TestDropTargetShards_NoOpto verify thatdropTargetShards()can be called safely within a configured workflow environment. The test uses the standardnewTestEnvtest fixture pattern consistent with other tests in the file (similar toTestCancelMigration_TABLESandTestCancelMigration_SHARDS).Coverage Impact:
dropTargetShardshad 0% test coveragetraffic_switcher.go:1399:dropTargetShardsVerification:
go test ./go/vt/vtctl/workflow -run TestDropTargetShards_NoOp -v
go test ./go/vt/vtctl/workflow -run TestDropTargetShards_NoOp -coverpkg=./go/vt/vtctl/workflow -coverprofile=c.out
go tool cover -func=c.out | grep dropTargetShards
Result: traffic_switcher.go:1399: dropTargetShards 75.0%
Backporting: Not required - this is a test-only change that improves code coverage without any functional modifications.
Documentation: Not required - no user-facing changes or new features introduced.
Related Issue(s)
Fixes #17284
Checklist
Deployment Notes
No deployment impact. This is a test-only change that increases code coverage.