-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient
#19085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhamza15
wants to merge
1
commit into
vitessio:main
Choose a base branch
from
mhamza15:reload-schema-req
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where `ReloadSchema` was incorrectly set to `req.DisableBinlogs` instead of `req.ReloadSchema` in `ExecuteFetchAsDba` and `ExecuteMultiFetchAsDba` Signed-off-by: Mohamed Hamza <[email protected]>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
ReloadSchema incorrectly using DisableBinlogs value in grpctmclient
ReloadSchema incorrectly using DisableBinlogs value in grpctmclientReloadSchema incorrectly using DisableBinlogs value in grpctmclient
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19085 +/- ##
==========================================
- Coverage 69.90% 69.89% -0.02%
==========================================
Files 1612 1612
Lines 215817 215789 -28
==========================================
- Hits 150865 150819 -46
- Misses 64952 64970 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arthurschreiber
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-22.0
Needs to be backport to release-22.0
Backport to: release-23.0
Needs to be backport to release-23.0
Component: TabletManager
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a small bug where
ReloadSchemawas incorrectly set toreq.DisableBinlogsinstead ofreq.ReloadSchemainExecuteFetchAsDbaandExecuteMultiFetchAsDba.Related Issue(s)
Checklist
Deployment Notes
AI Disclosure