-
Notifications
You must be signed in to change notification settings - Fork 2.3k
e2e: disable gRPC GOAWAY/too_many_pings keepalive errors in e2e CI
#19083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timvaillancourt
wants to merge
4
commits into
vitessio:main
Choose a base branch
from
timvaillancourt:e2e-grpc-keepalive-relax
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
e2e: disable gRPC GOAWAY/too_many_pings keepalive errors in e2e CI
#19083
timvaillancourt
wants to merge
4
commits into
vitessio:main
from
timvaillancourt:e2e-grpc-keepalive-relax
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <[email protected]>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <[email protected]>
e2e: disable GOAWAY/too_many_pings errors in e2e CIe2e: disable gRPC GOAWAY/too_many_pings keepalive errors in e2e CI
mhamza15
approved these changes
Dec 24, 2025
Co-authored-by: Mohamed Hamza <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19083 +/- ##
=======================================
Coverage 69.90% 69.90%
=======================================
Files 1612 1612
Lines 215817 215789 -28
=======================================
- Hits 150865 150849 -16
+ Misses 64952 64940 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables too-many-ping protection in gRPC when running e2e tests with
test.go. This is achieved by settingGRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATAto0Context from docs:
and
Today, many e2e tests connect/reconnect to the gRPC server too quickly and hit the
GOAWAY/too_many_pingserror. When this occurs, the victim test has to wait theGRPC_ARG_HTTP2_MIN_RECV_PING_INTERVAL_WITHOUT_DATA_MSdefault of 300000 milliseconds (5 minutes) doing nothing 😱. This protection makes sense in a normal world, but in an e2e test all running on localhost we don't really careWhen tests hit this, we see this error and pause for 5min:
E1218 18:18:06.674435 32993 component.go:44] [transport] Client received GoAway with error code ENHANCE_YOUR_CALM and debug data equal to ASCII "too_many_pings".Docs: https://github.com/grpc/grpc/blob/master/doc/keepalive.md
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure