Generate race unit tests

[mhamza15]

Description

The race unit tests workflow would not fail in CI due to a missing set -exo pipefail, allowing the tests to fail but the overall job to still succeed. This PR adds them to the workflow generator, so that this issue is fixed and so they stay in sync in the future.

Going to backport this to release branches as well so that their CI is fixed.

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

AI Disclosure

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[arthurschreiber]

@mhamza15 I think the renaming of the jobs is not intended, but breaks the current configuration of the required status checks.

So either we need to change the repo config (which will then require everyone to merge master into their branches to help them pass the required status check config), or we need to make sure we keep the existing name here.

[mhamza15]

Yep good call. Weirdly enough this one is still required, I wonder if it used to exist and was required before:

Will change regardless 👍

[mhamza15]

Ah it matches on the job name, not the workflow name + job name. So this one is fine, the evalengine one needs to be updated.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.90%. Comparing base (749fe54) to head (4d7f3eb).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #19078      +/-   ##
==========================================
+ Coverage   69.88%   69.90%   +0.02%     
==========================================
  Files        1610     1612       +2     
  Lines      215431   215789     +358     
==========================================
+ Hits       150551   150850     +299     
- Misses      64880    64939      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[timvaillancourt]

@mhamza15 one failing CI, but LGTM assuming that is fixed

[mattlord]

❤️