-
Notifications
You must be signed in to change notification settings - Fork 2.3k
EmergencyReparentShard: support ignored file-based replicas
#19069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
timvaillancourt
wants to merge
9
commits into
vitessio:main
Choose a base branch
from
timvaillancourt:dont-reparent-file-based
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
EmergencyReparentShard: support ignored file-based replicas
#19069
timvaillancourt
wants to merge
9
commits into
vitessio:main
from
timvaillancourt:dont-reparent-file-based
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: for this PR to move forward,
EmergencyReparentShardmust know which replicas are semi-sync-enabled - currently it does notThis PR changes the
EmergencyReparentShardbehaviour for shards with mixed GTID-based and file-based replication positions. The only example scenario I can think of being a Vitess cluster in an "import phase" from a file-based sourceToday (v23 stable) a shard in this mixed state will hard-fail to reparent. On one hand that is very safe, and on another it is very dangerous - an unplanned problem with the
PRIMARYwill not be fixed, likely resulting in downtimeThis PR changes the behaviour to ignore the file-based replica and move forward with the reparent if we can ensure the replica is not a semi-sync acker
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure