-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix some issues with the backport / forwardport workflow #18954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18954 +/- ##
==========================================
+ Coverage 69.88% 69.91% +0.02%
==========================================
Files 1610 1610
Lines 215431 215659 +228
==========================================
+ Hits 150551 150770 +219
- Misses 64880 64889 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Arthur Schreiber <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]>
6ef3393 to
52a173d
Compare
|
📝 Documentation updates detected! Updated existing suggestion: Document automated backport and forwardport workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few writes to $GITHUB_OTPUT that are unused and that I think can all be removed.
Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
|
📝 Documentation updates detected! Updated existing suggestion: Add changelog entry for GitHub Actions automation |
timvaillancourt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, caveat: it's unclear what changed exactly, so I've only glanced for obvious problems
|
📝 Documentation updates detected! Updated existing suggestion: Document automated backport and forwardport workflow |
Description
Adds back the backport workflow with some improvements:
vitess-bottokenRelated Issue(s)
Checklist
Deployment Notes
AI Disclosure