Skip to content

vtorc: add support for dynamic enable/disable of ERS by keyspace/shard #17985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timvaillancourt merged 42 commits into from
Sep 3, 2025

fix typo

4ea4fc4
Select commit
Loading
Failed to load commit list.
Merged

vtorc: add support for dynamic enable/disable of ERS by keyspace/shard #17985

fix typo
4ea4fc4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 3, 2025 in 0s

67.50% (-0.02%) compared to 1baf02b

View this Pull Request on Codecov

67.50% (-0.02%) compared to 1baf02b

Details

Codecov Report

❌ Patch coverage is 34.80176% with 148 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.50%. Comparing base (1baf02b) to head (4ea4fc4).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtorc/logic/topology_recovery.go 0.00% 52 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 0.00% 49 Missing ⚠️
go/cmd/vtctldclient/command/topology.go 14.28% 24 Missing ⚠️
go/vt/vtorc/logic/tablet_discovery.go 39.13% 14 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 5 Missing ⚠️
go/vt/topotools/keyspace.go 50.00% 2 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17985      +/-   ##
==========================================
- Coverage   67.52%   67.50%   -0.02%     
==========================================
  Files        1607     1607              
  Lines      263338   263518     +180     
==========================================
+ Hits       177812   177892      +80     
- Misses      85526    85626     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov