VTGate: Session in StreamExecute response as default#17907
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
4dfc37b to
9042955
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17907 +/- ##
==========================================
+ Coverage 67.50% 67.54% +0.04%
==========================================
Files 1597 1597
Lines 259761 259770 +9
==========================================
+ Hits 175344 175456 +112
+ Misses 84417 84314 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Do we have an issue created for what needs to be done in v23? |
deepthi
approved these changes
Mar 5, 2025
GuptaManan100
approved these changes
Mar 6, 2025
Contributor
GuptaManan100
left a comment
There was a problem hiding this comment.
LGTM. Deepthi's comment needs to be addressed.
systay
approved these changes
Mar 6, 2025
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Member
Author
Issue exists now #17913 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables
grpc-send-session-in-streamingastrueby default and mark the flag as deprecated to be removed from future release.Related Issue(s)
Checklist
Deployment Notes