Skip to content

[release-19.0] Bump to v19.0.10-SNAPSHOT after the v19.0.9 release#17596

Merged
frouioui merged 1 commit into
release-19.0from
release-19.0-back-to-dev-mode-3
Jan 21, 2025
Merged

[release-19.0] Bump to v19.0.10-SNAPSHOT after the v19.0.9 release#17596
frouioui merged 1 commit into
release-19.0from
release-19.0-back-to-dev-mode-3

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

Includes the changes required to go back into dev mode (v19.0.10-SNAPSHOT) after the release of v19.0.9.

…e `v19.0.9` release

This commit was made automatically by the vitess-releaser tool.

See https://github.com/vitessio/vitess-releaser

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot added the Component: General Changes throughout the code base label Jan 21, 2025
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented Jan 21, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot Bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 21, 2025
@vitess-bot vitess-bot mentioned this pull request Jan 21, 2025
26 tasks
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.24%. Comparing base (16e38f1) to head (44f6e64).
Report is 1 commits behind head on release-19.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17596      +/-   ##
================================================
- Coverage         65.25%   65.24%   -0.02%     
================================================
  Files              1560     1560              
  Lines            238354   238354              
================================================
- Hits             155543   155510      -33     
- Misses            82811    82844      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui added this to the v19.0.10 milestone Jan 21, 2025
@frouioui frouioui merged commit 86f2e79 into release-19.0 Jan 21, 2025
@frouioui frouioui deleted the release-19.0-back-to-dev-mode-3 branch January 21, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants