Skip to content

Flakes: skip flaky check that ETA for a VReplication VDiff2 Progress command is in the future. #13804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 1 commit into from
Aug 18, 2023
Merged

Flakes: skip flaky check that ETA for a VReplication VDiff2 Progress command is in the future. #13804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions go/test/endtoend/vreplication/vdiff_helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,20 @@ func waitForVDiff2ToComplete(t *testing.T, ksWorkflow, cells, uuid string, compl
// The timestamp format allows us to compare them lexicographically.
// We don't test that the ETA always increases as it can decrease based on how
// quickly we're doing work.
if info.Progress.ETA != "" {
// If we're operating at the second boundary then the ETA can be up
// to 1 second in the past due to using second based precision.
loc, _ := time.LoadLocation("UTC")
require.GreaterOrEqual(t, info.Progress.ETA, time.Now().Add(-time.Second).In(loc).Format(vdiff2.TimestampFormat))
}

// Commenting out this check for now as it is quite flaky in Github CI: we sometimes get a difference of
// more than 1s between the ETA and the current time, empirically seen 2s when it has failed,
// but presumably it can be higher. Keeping the code here for now in case we want to re-enable it.

/*
if info.Progress.ETA != "" {
// If we're operating at the second boundary then the ETA can be up
// to 1 second in the past due to using second based precision.
loc, _ := time.LoadLocation("UTC")
require.GreaterOrEqual(t, info.Progress.ETA, time.Now().Add(-time.Second).In(loc).Format(vdiff2.TimestampFormat))
}
*/

if !first {
require.GreaterOrEqual(t, info.Progress.Percentage, previousProgress.Percentage)
}
Expand Down