Skip to content

Back to dev mode after v17.0.1#13663

Merged
shlomi-noach merged 1 commit into
vitessio:release-17.0from
planetscale:release-17.0-back_to_dev-1
Aug 8, 2023
Merged

Back to dev mode after v17.0.1#13663
shlomi-noach merged 1 commit into
vitessio:release-17.0from
planetscale:release-17.0-back_to_dev-1

Conversation

@frouioui

Copy link
Copy Markdown
Member

Includes the changes required to go back into dev mode (v17.0.2-SNAPSHOT) after the release of v17.0.1.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot

vitess-bot Bot commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot Bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 28, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jul 28, 2023
@frouioui frouioui added this to the v17.0.2 milestone Jul 31, 2023
@frouioui frouioui added Component: General Changes throughout the code base and removed Component: General Changes throughout the code base labels Aug 7, 2023
@shlomi-noach

Copy link
Copy Markdown
Contributor

Upgrade Downgrade Testing Reparent New Vtctl / Run Upgrade Downgrade Test keeps failing - I restarted it like 5 times.

@shlomi-noach

Copy link
Copy Markdown
Contributor

I removed Upgrade Downgrade Testing Reparent New Vtctl from Required tests list for release-17.0. Now merging.

@shlomi-noach shlomi-noach merged commit 2da865e into vitessio:release-17.0 Aug 8, 2023
@shlomi-noach shlomi-noach deleted the release-17.0-back_to_dev-1 branch August 8, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants