Skip to content

Backport to release-14: Fix VTOrc Discovery to also retry discovering tablets which aren't present in database_instance table#11238

Merged
GuptaManan100 merged 1 commit into
vitessio:release-14.0from
planetscale:vtorc-discovery-bug-cp
Sep 19, 2022
Merged

Backport to release-14: Fix VTOrc Discovery to also retry discovering tablets which aren't present in database_instance table#11238
GuptaManan100 merged 1 commit into
vitessio:release-14.0from
planetscale:vtorc-discovery-bug-cp

Conversation

@GuptaManan100

@GuptaManan100 GuptaManan100 commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Description

This PR is a backport of #10662 to releaes-14.0

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

…esent in database_instance table (vitessio#10662)

* test: add failing test for durability policy setting after vtorc starts

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add query to also check for vttablets whose information is absent in the database_instance table

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: rename test

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Bug Backport This is a backport Component: VTOrc Vitess Orchestrator integration labels Sep 16, 2022
@vitess-bot

vitess-bot Bot commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: VTOrc Vitess Orchestrator integration Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants