Fix how the status of the general prerequisite is handled#91
Merged
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
| return mi, nil | ||
| } | ||
| mi.State.Issue.General.InverseItemStatus() | ||
| if mi.IsDone { |
Member
There was a problem hiding this comment.
Should this logic be inverted? if mi.IsDone mi.State.Issue.General.MarkAllAsDone() ?
Member
Author
There was a problem hiding this comment.
No, we want to invert the status. If IsDone is true, we are setting all the fields to false and after the if/else block we set isDone to false.
systay
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue where the status (done/not done) of the general prerequisite step was not saved properly on the issue. Now, in the UI when marking the item as done/not done, all the items of the list are checked or unchecked.