Move PRs to newer milestone when doing RC-1#106
Merged
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
rohit-nayak-ps
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During RC-1's code freeze, we create the new release branch and a new milestone (i.e.
v21.0.0), however we were not moving the PRs from the previous milestone (v20.0.0), into the new one (v21.0.0). Meaning that we had PRs on themainbranch that were still assigned to thev20.0.0milestone although these specific PRs were never going to make it to thev20.0.0release (maybe they would have thanks to backport, but that does not matter).Eventually during the release step of GA, we migrate all the opened PRs from the
v20.0.0milestone to the newv21.0.0milestone, but that happens too late already.This PR fixes this issue by migrating all opened PRs from the current to the next milestone during RC-1's code freeze.