Add version flag, contribution doc, small UI enhancements#102
Merged
Conversation
Member
rohit-nayak-ps
commented
Jun 19, 2024
rohit-nayak-ps
commented
- Show version which includes the last git commit
- Initial Makefile
- Minor text and style mods
- Initial Contribution doc for local install and development tips/tricks
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
changed the title
frouioui
reviewed
Jun 19, 2024
Comment on lines
+28
to
+31
| ### Labels | ||
|
|
||
| Create the following labels on your fork: `Component: General`, `Type: Release`, `Do Not Merge`. This is required | ||
| because the Releaser tool uses these labels to create the Release issue. The issue URL is shown in the UI that comes up. |
frouioui
approved these changes
Jun 19, 2024
Member
frouioui
left a comment
frouioui
left a comment
There was a problem hiding this comment.
The -v flag does not work when it is run outside of the vitess-releaser folder, but I think that's already pretty good, at least when installing the tool we get an idea of what commit we are on.
I will edit the README to use that new make command.
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Member
|
Thank you @rohit-nayak-ps ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.