Skip to content

Chore: Adding lint workflow and fixing format issues #545

Open
DhairyaMajmudar wants to merge 7 commits into
vitessio:mainfrom
DhairyaMajmudar:lint_workflow
Open

Chore: Adding lint workflow and fixing format issues #545
DhairyaMajmudar wants to merge 7 commits into
vitessio:mainfrom
DhairyaMajmudar:lint_workflow

Conversation

@DhairyaMajmudar
Copy link
Copy Markdown
Contributor

@DhairyaMajmudar DhairyaMajmudar commented May 19, 2024 •
edited
Loading

Tasks Done

  1. Added TS linting, formating and typecheck workflow
  2. Updated scripts in package.json for formatting the files
  3. Formatted several files by the added command.

Issue Number:
#539

Screenshots/videos:
N/A

If relevant, did you update the documentation?

N/A

Summary
Code files are now formatted

@DhairyaMajmudar DhairyaMajmudar requested a review from frouioui as a code owner May 19, 2024 16:46
@DhairyaMajmudar DhairyaMajmudar mentioned this pull request May 19, 2024
Closed
frouioui
frouioui reviewed May 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, there are several warnings left by the new workflow in https://github.com/vitessio/arewefastyet/pull/545/files

Comment thread .github/workflows/typescript_lint.yml Outdated
@DhairyaMajmudar
Copy link
Copy Markdown
Contributor Author

DhairyaMajmudar commented May 21, 2024

Thank You @frouioui I have made the required changes, currently the workflow is failing since some files are not formatted and due to failing type checks.

Looking forward to fix these in upcoming PRs.

This one is ready to merge : )

@frouioui
Copy link
Copy Markdown
Member

frouioui commented Jul 30, 2024

Hello @DhairyaMajmudar, there are many conflicts, could you fix them before I merge this?

@DhairyaMajmudar
Copy link
Copy Markdown
Contributor Author

DhairyaMajmudar commented Jul 30, 2024

Hello @DhairyaMajmudar, there are many conflicts, could you fix them before I merge this?

Sure thing : )

@DhairyaMajmudar
Copy link
Copy Markdown
Contributor Author

DhairyaMajmudar commented Jul 30, 2024

Hi @frouioui I've resolved the conflicts and also fixed formatting issues in several newly added files.

@DhairyaMajmudar DhairyaMajmudar changed the title Fix: Adding lint workflow and updating the files Fix: Adding lint workflow and fixing format issues Jul 30, 2024
@DhairyaMajmudar DhairyaMajmudar changed the title Fix: Adding lint workflow and fixing format issues Chore: Adding lint workflow and fixing format issues Aug 6, 2024
@DhairyaMajmudar
Copy link
Copy Markdown
Contributor Author

DhairyaMajmudar commented Aug 6, 2024

@frouioui @notfelineit a kind ping for PR review.

DhairyaMajmudar and others added 6 commits August 27, 2024 22:04
@DhairyaMajmudar @Jad31
adding lint workflow and scripts
960c4b8
@DhairyaMajmudar @Jad31
adding lint workflow
057f1a1
@DhairyaMajmudar @frouioui @Jad31
Update .github/workflows/typescript_lint.yml
b2d9e25 
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Signed-off-by: Dhairya Majmudar <124715224+DhairyaMajmudar@users.noreply.github.com>
@DhairyaMajmudar @Jad31
formating new files
6afeca3
@DhairyaMajmudar @Jad31
updating and adding new scritps
682e8dc
@DhairyaMajmudar @Jad31
fixing file format
cc6a68b
@Jad31
feat: format
21fb4f7 
Signed-off-by: Jad Chahed <jad.chahed@bashroom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DhairyaMajmudar @frouioui @Jad31