fix: rewrite CJS specific funcs/vars in plugins#8227
Merged
Conversation
antfu
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #8139, plugins were not working when it is imported as ESM (for example, when
type='module'is set inpackage.json) reported at #8139 (comment).This PR rewrites
require/__dirnameto usecreateRequire.Another way to solve this is to set
rollup.cjsBridgeinbuild.config.tstotrue.Should
p4-importantbe used for alpha versions too?Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).