Skip to content

fix(server): drain stdin when not interactive #20837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 2 commits into from
Sep 30, 2025
Merged

fix(server): drain stdin when not interactive #20837

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6163d0c
fix(dev): drain stdin when not interactive
thatguystone Sep 24, 2025
a473fc0
Merge branch 'main' into main
bluwy Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/vite/src/node/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,12 +1634,17 @@ const parentSigtermCallback: SigtermCallback = async (signal, exitCode) => {
await Promise.all([...sigtermCallbacks].map((cb) => cb(signal, exitCode)))
}

const drain = () => {}

export const setupSIGTERMListener = (
callback: (signal?: 'SIGTERM', exitCode?: number) => Promise<void>,
): void => {
if (sigtermCallbacks.size === 0) {
process.once('SIGTERM', parentSigtermCallback)
if (process.env.CI !== 'true') {
if (!process.stdin.isTTY) {
process.stdin.on('data', drain)
}
process.stdin.on('end', parentSigtermCallback)
}
}
Expand All @@ -1653,6 +1658,7 @@ export const teardownSIGTERMListener = (
if (sigtermCallbacks.size === 0) {
process.off('SIGTERM', parentSigtermCallback)
if (process.env.CI !== 'true') {
process.stdin.off('data', drain)
process.stdin.off('end', parentSigtermCallback)
}
}
Expand Down
Loading