Skip to content

fix(create-vite): fix installing dependencies #20826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 5 commits into from
Sep 23, 2025
+6 −5
Merged

fix(create-vite): fix installing dependencies #20826

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2c7500
fix(create-vite): Fix installing dependencies
nicolo-ribaudo Sep 23, 2025
a8df930
Handle the command name in run()
nicolo-ribaudo Sep 23, 2025
2b324ef
Remove extra type
nicolo-ribaudo Sep 23, 2025
2a0cb57
chore: format
sapphi-red Sep 23, 2025
76a5360
chore: update
sapphi-red Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/create-vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import fs from 'node:fs'
import path from 'node:path'
import { fileURLToPath } from 'node:url'
import type { SpawnOptions } from 'node:child_process'
import spawn from 'cross-spawn'
import mri from 'mri'
import * as prompts from '@clack/prompts'
Expand Down Expand Up @@ -357,14 +358,14 @@ const renameFiles: Record<string, string | undefined> = {

const defaultTargetDir = 'vite-project'

function run(...params: Parameters<typeof spawn.sync>) {
const { status, error } = spawn.sync(...params)
function run([command, ...args]: string[], options?: SpawnOptions) {
const { status, error } = spawn.sync(command, args, options)
if (status != null && status > 0) {
process.exit(status)
}

if (error) {
console.error(`\n${params.slice(0, -1).join(' ')} error!`)
console.error(`\n${command} ${args.join(' ')} error!`)
console.error(error)
process.exit(1)
}
Expand All @@ -378,7 +379,7 @@ function install(root: string, agent: string) {
return
}
prompts.log.step(`Installing dependencies with ${agent}...`)
run(agent, getInstallCommand(agent), {
run(getInstallCommand(agent), {
stdio: 'inherit',
cwd: root,
})
Expand All @@ -390,7 +391,7 @@ function start(root: string, agent: string) {
return
}
prompts.log.step('Starting dev server...')
run(agent, getRunCommand(agent, 'dev'), {
run(getRunCommand(agent, 'dev'), {
stdio: 'inherit',
cwd: root,
})
Expand Down
Loading