Skip to content

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented May 22, 2025

Description

Built on top of #19936

This PR adds this.meta.viteVersion. This would allow plugins to get the version of Vite the dev server / build is running. It is slightly different from import { VERSION } from 'vite' as that would resolve to the dependency of that plugin.

Rollup has this.meta.rollupVersion and Rolldown has this.meta.rolldownVersion.

close #19355

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label May 22, 2025
patak-dev
patak-dev previously approved these changes May 26, 2025
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this feature will be controversial. We could move forward with this one and #19936. @sapphi-red I'll let you merge them, in case you still want to wait until the next team meeting to discuss them.

@sapphi-red sapphi-red force-pushed the feat/add-this-meta-vite-version branch from 2530d09 to 23b9c21 Compare May 27, 2025 02:52
@sapphi-red sapphi-red marked this pull request as ready for review May 27, 2025 02:53
@sapphi-red sapphi-red merged commit f55bf41 into vitejs:main May 27, 2025
16 checks passed
@sapphi-red sapphi-red deleted the feat/add-this-meta-vite-version branch May 27, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants