Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Sep 17, 2024

Description

The test I added doesn't fail on main since Vitest probably just exits regardless of hanging resource. However, it can be used to test it manually and this hangs on main:

pnpm -C playground/css build -c vite.config-sass-modern-compiler-build.js

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa changed the title fix(css): instantiate sass compiler only once fix(css): ensure sass compiler initialized only once Sep 17, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review September 18, 2024 00:45
@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: css labels Sep 18, 2024
@bluwy bluwy merged commit 4cc5322 into vitejs:main Sep 23, 2024
@hi-ogawa hi-ogawa deleted the fix-sass-compiler-init-once branch September 23, 2024 23:31
sapphi-red pushed a commit to sapphi-red/vite that referenced this pull request Sep 24, 2024
sapphi-red added a commit that referenced this pull request Sep 24, 2024
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: css p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vite build hangs with multiple scss input files when using 'modern-compiler'

3 participants