Skip to content

fix(worker): fix importScripts injection breaking iife code #17827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 6 commits into from
Aug 6, 2024
Merged

fix(worker): fix importScripts injection breaking iife code #17827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b5a840
fix(worker): fix `injectScripts` injection
hi-ogawa Aug 6, 2024
10fb68d
chore: prettier-ignore
hi-ogawa Aug 6, 2024
a2e648b
Revert "chore: prettier-ignore"
hi-ogawa Aug 6, 2024
f316326
chore: prettierignore
hi-ogawa Aug 6, 2024
70c746c
test: add new worker
hi-ogawa Aug 6, 2024
4e96e12
Revert "test: add new worker"
hi-ogawa Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ playground/html/invalid.html
playground/html/valid.html
playground/external/public/[email protected]
playground/ssr-html/public/[email protected]
playground/worker/classic-worker.js
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export function webWorkerPlugin(config: ResolvedConfig): Plugin {
}
if (injectEnv) {
const s = new MagicString(raw)
s.prepend(injectEnv)
s.prepend(injectEnv + ';\n')
return {
code: s.toString(),
map: s.generateMap({ hires: 'boundary' }),
Expand Down
2 changes: 2 additions & 0 deletions playground/worker/classic-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
(() => {})() // this is to test `importScripts` injection doesn't break the code

let base = `/${self.location.pathname.split('/')[1]}`
if (base.endsWith('.js') || base === `/worker-entries`) base = '' // for dev

Expand Down