fix(manifest): preserve pure css chunk assets#14297
Merged
sapphi-red merged 7 commits intovitejs:mainfrom Sep 10, 2023
Merged
Conversation
|
|
Member
Author
|
Can you help check this PR in svelte-kit? Thanks @benmccann |
Member
|
I wonder if it's possible to handle when removing the pure CSS chunk. vite/packages/vite/src/node/plugins/css.ts Lines 768 to 775 in 66a97be |
Member
Author
Yeah ,that would be more simple 👍 |
Collaborator
Yes, I see SvelteKit generating the preload header tags when linked against this PR. Thank you so much for fixing this!! |
benmccann
approved these changes
Sep 7, 2023
bluwy
approved these changes
Sep 8, 2023
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
|
Looks like the ones that passed in main also passed here. |
Gaubee
pushed a commit
to Gaubee/vite
that referenced
this pull request
Sep 13, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #14244
pureCssChunkwill be removed totally with itsimportedAssets. Thus theseimportedAssetswould be orphaned in themanifest.json.This PR tries to preserve these
importedAssetsvia attaching them withpureCssChunk's emitted css.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).