fix: include vite/types/* in exports field#14296
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Sep 6, 2023
yuheiy:export-vite-types
Merged
fix: include vite/types/* in exports field#14296sapphi-red merged 1 commit intovitejs:mainfrom yuheiy:export-vite-types
vite/types/* in exports field#14296sapphi-red merged 1 commit intovitejs:mainfrom
yuheiy:export-vite-types
Conversation
|
|
bluwy
reviewed
Sep 5, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
This sounds good to me. Presumably we only document /// <reference types="vite/types/importMeta" /> and that bypasses the exports which made it work.
Note though that this change is going into Vite 5. And Vite 5 should also include #14279 which fixes the core issue in Astro in the first place that needed to import the vite/types/*. Unless we backport this to Vite 4.
bluwy
approved these changes
Sep 6, 2023
vite/types/*vite/types/* in exports field
sapphi-red
approved these changes
Sep 6, 2023
Gaubee
pushed a commit
to Gaubee/vite
that referenced
this pull request
Sep 13, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR exports the files under
vite/types/*. This makes internal type definitions available for external reference.Additional context
In Astro, we are referencing files within the
typesdirectory to provide users with type information likeViteHotContextandImportGlobFunction.https://github.com/withastro/astro/blob/b6066e109c5807f16dd81e07c81f300459e12897/packages/astro/import-meta.d.ts#L12-L20
However, these are not defined in
exportsfield in Vite'spackage.json. As a result, when runningtscto check the contents ofimport-meta.d.ts, an error occurs. To resolve this, we need to extend theexportsfield in Vite'spackage.json.ref:
withastro/astro#8360 (comment)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).