fix: revert only watch .env files in envDir (#12587) #13217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 26d8e72.
|
|
patak-dev
added
the
p3-minor-bug
sapphi-red
approved these changes
May 16, 2023
|
Ah, I see. Ok, let's merge the revert for now |
|
Is there an original issue to track this bug? |
|
@sun0day not in Vite core at least. @bartlomieju, do you have a link to some of the reports you got in Deno? |
|
Thanks for a quick fix, here's the issue with user reports: denoland/deno#19067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #12587, commit 26d8e72.
Description
@bartlomieju reported Windows crashes and he tracked the issue down to this PR.
disableGlobbing: trueis used above, so we can't use globbing. @sapphi-red wasdisableGlobbingneeded when implementing #8939, or it was an optimization because globbing was used anymore? @sun0day I think we could revert and then review how to reapply the optimization (if it is worth doing so).What is the purpose of this pull request?