fix(create-vite): fix installing dependencies

[nicolo-ribaudo]

Description

Fixes #20823, #20824

This PR does not add tests. There seems to be already tests for this (

vite/packages/create-vite/__tests__/cli.spec.ts

Lines 254 to 269 in 0021527

	test('accepts immediate flag', () => {
	const { stdout } = run([projectName, '--template', 'vue', '--immediate'], {
	cwd: __dirname,
	})
	expect(stdout).not.toContain('Install and start now?')
	expect(stdout).toContain(`Scaffolding project in ${genPath}`)
	expect(stdout).toContain('Installing dependencies')
	})
	test('accepts immediate flag and skips install prompt', () => {
	const { stdout } = run([projectName, '--template', 'vue', '--no-immediate'], {
	cwd: __dirname,
	})
	expect(stdout).not.toContain('Install and start now?')
	expect(stdout).not.toContain('Installing dependencies')
	expect(stdout).toContain(`Scaffolding project in ${genPath}`)

), and I do not understand why they were passing. It seems like often this type of changes is done without tests (e.g. #20821), so hopefully somebody else can add some separately in a follow up :)

[bluwy]

A bit nitpicky, but I think I'd modify this part as something like this instead:

vite/packages/create-vite/src/index.ts

Lines 381 to 384 in 0021527

	run(agent, getInstallCommand(agent), {
	stdio: 'inherit',
	cwd: root,
	})

const [pm, ...args] = getInstallCommand(agent)
run(pm, args, ...)

[sapphi-red]

I do not understand why they were passing.

It's probably because the install itself is skipped in the tests 🙈

vite/packages/create-vite/src/index.ts

Lines 375 to 380 in 2a0cb57

	if (process.env._VITE_TEST_CLI) {
	prompts.log.step(
	`Installing dependencies with ${agent}... (skipped in test)`,
	)
	return
	}

[nicolo-ribaudo]

Uh linting is failing, give me a second... I was editing through GitHub rather than locally 😅

[sapphi-red]

Ah, I've fixed it 🫡 (saw the comment after doing it)

[sapphi-red]

Thank you for the PR 💚

[nicolo-ribaudo]

Thanks for fixing it up!