-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Closed
Copy link
Labels
p3-minor-bugAn edge case that only affects very specific usage (priority)An edge case that only affects very specific usage (priority)
Description
Describe the bug
If either ssr.noExternal or environments.ssr.resolve.noExternal are set to true then other values should be ignored and both should be resolved to true in the config. They are currently incorrectly merged to an array e.g. ['some-dep', true].
Reproduction
https://github.com/jamesopstad/vite-ssr-no-external-repro
Steps to reproduce
Run pnpm i followed by pnpm dev. Inspect vite.config.ts and logged output.
System Info
System:
OS: macOS 15.5
CPU: (12) arm64 Apple M3 Pro
Memory: 258.20 MB / 36.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 24.2.0 - ~/.nvm/versions/node/v24.2.0/bin/node
Yarn: 1.22.22 - ~/.nvm/versions/node/v24.2.0/bin/yarn
npm: 11.3.0 - ~/.nvm/versions/node/v24.2.0/bin/npm
pnpm: 10.12.4 - ~/.nvm/versions/node/v24.2.0/bin/pnpm
Browsers:
Chrome: 138.0.7204.169
Safari: 18.5Used Package Manager
pnpm
Logs
No response
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
sergiocarneiro
Metadata
Metadata
Assignees
Labels
p3-minor-bugAn edge case that only affects very specific usage (priority)An edge case that only affects very specific usage (priority)