calls transform function on constant attribute updates #9741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bugs that show up when inputting an accessor as a string instead of a function
|
@Pessimistress Could you take a look at this PR? Thanks! |
felixpalmer
requested changes
Aug 20, 2025
There was a problem hiding this comment.
Nice, I think I've hit this before. I think it primarily affects IconLayer as having a static icon is a common pattern.
Could you add a test case toattribute.spec.ts? 'standard accessor with transform' could be used as a guide. Run tests with yarn test browser
|
@felixpalmer sorry to ping, but could you take a look again? |
felixpalmer
approved these changes
Aug 29, 2025
|
You need to run yarn lint fix |
My bad, fixed it @felixpalmer |
|
The tests are still failing. Use ‘yarn test browser’ to run locally and try to debug&fix the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs that show up when inputting an accessor as a string instead of a function.
Background
The bug can be seen clearly in this codepen: https://codepen.io/heebeegb/pen/RNWLyXB?editors=0010
Swapping the getIcon accessor to a function will make it work - this pull request calls the transform function for constant attributes as well, fixing the issue.
I changed the typing of "value" to any as the transform function has arbitrary inputs. Strings, numbers, and number arrays are all passed into setConstantValue already, this pipes them into the transform call if it exists.
Change List