Skip to content

Invoke onError when GL context is lost #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2021
Merged

Invoke onError when GL context is lost #5731

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91602fc
Clean up Deck's internal method bindings
Pessimistress May 5, 2021
3b94332
Invoke onError when GL context is lost
Pessimistress May 5, 2021
745cf66
Merge branch 'master' into x/context-lost
Pessimistress May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions modules/core/src/lib/deck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,18 @@ export default class Deck {
}

_createAnimationLoop(props) {
const {width, height, gl, glOptions, debug, useDevicePixels, autoResizeDrawingBuffer} = props;
const {
width,
height,
gl,
glOptions,
debug,
onError,
onBeforeRender,
onAfterRender,
useDevicePixels,
autoResizeDrawingBuffer
} = props;

return new AnimationLoop({
width,
Expand All @@ -491,12 +502,19 @@ export default class Deck {
autoResizeDrawingBuffer,
autoResizeViewport: false,
gl,
onCreateContext: opts => createGLContext({...glOptions, ...opts, canvas: this.canvas, debug}),
onCreateContext: opts =>
createGLContext({
...glOptions,
...opts,
canvas: this.canvas,
debug,
onContextLost: _ => onError?.(new Error(`WebGL context is lost`))
}),
onInitialize: context => this._setGLContext(context.gl),
onRender: this._onRenderFrame.bind(this),
onBeforeRender: props.onBeforeRender,
onAfterRender: props.onAfterRender,
onError: props.onError
onBeforeRender,
onAfterRender,
onError
});
}

Expand Down