Don't copy the response Transfer-Encoding header #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops `express-http-proxy` from preserving the response's `Transfer-Encoding` header. Without this, when `express-http-proxy` tries to proxy a response with `Transfer-Encoding: chunked` set, the response is de-chunked by waiting on all the chunks and joining them, indeed, a Content-Lenght header is computed and set if intercepting. But trying to send a response with both `Content-Length` and `Transfer-Encodign: chunked` fails with a `Parse error`, because it doesn't make sense. Thus, we explicitly skip copying over `Transfer-Encoding`.
This was referenced Feb 18, 2016
|
Any chance on getting this merged and released soon? |
|
I'm ..becoming sure that express-http-proxy is dead, we've switched over to node-http-proxy since (which doesn't have the issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops
express-http-proxyfrom preserving the response'sTransfer-Encodingheader.Without this, when
express-http-proxytries to proxy a response withTransfer-Encoding: chunkedset, the response is de-chunked by waitingon all the chunks and joining them, indeed, a
Content-Lengthheader iscomputed and set if intercepting. But trying to send a response with
both
Content-LengthandTransfer-Encoding: chunkedfails with aParse error, because it doesn't make sense.Thus, we explicitly skip copying over
Transfer-Encoding.(For example, Puma with Rails 5 always sends replies that way.)