Add kernel message on integration test failure #1129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshjms
force-pushed
the
add-dmesg
branch
2 times, most recently
from
a7eb8ec to
0bf90d3
Compare
|
Hmm, the kernel messages don't seem to help. |
Signed-off-by: joshjms <[email protected]>
|
I think that even if this doesn't help for the current flake issue, it might help us debug for future errors. |
|
Kernel messages are unlikely to be helpful; it would be more appropriate to collect Firecracker/containerd/vhive logs. |
|
I agree, although I think that there will be no harm done with including the kernel messages to debug containerd for a more comprehensive logging. This is also used in containerd's CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, running separate instances of firecracker-containerd also produces the same flake. Adding kernel message logging on failure might help us debug the cause.
Ref: #1113
Implementation Notes ⚒️
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.