Skip to content

Change UrlBehavior.static_suffix to ResolvedVc<Option<RcStr>>#89921

Merged
lukesandberg merged 1 commit into
canaryfrom
longer_vc
Feb 12, 2026
Merged

Change UrlBehavior.static_suffix to ResolvedVc<Option<RcStr>>#89921
lukesandberg merged 1 commit into
canaryfrom
longer_vc

Conversation

@lukesandberg

@lukesandberg lukesandberg commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Changes UrlBehavior.static_suffix from Option<RcStr> to ResolvedVc<Option<RcStr>> so that css_url_suffix stays as a Vc longer instead of being eagerly resolved at the call site. This improves caching behavior by keeping the value cell-based through the chunking context construction.

  • Updated UrlBehavior struct definition in turbopack-core
  • Updated default fallbacks in browser/nodejs chunking contexts
  • Updated CSS url reference consumer to .await? the ResolvedVc
  • Replaced .owned().await? with .to_resolved().await? in next-core callers

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lukesandberg lukesandberg marked this pull request as ready for review February 12, 2026 16:56
@nextjs-bot

nextjs-bot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

Keep css_url_suffix as a Vc longer by storing it as a ResolvedVc in
UrlBehavior instead of eagerly resolving it to Option<RcStr>.
@codspeed-hq

codspeed-hq Bot commented Feb 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing longer_vc (c264db0) with canary (ff63646)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot

Copy link
Copy Markdown
Contributor

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 508ms 507ms ▁▁▁▁▁
Cold (Ready in log) 471ms 465ms ▁▂▁▂▂
Cold (First Request) 1.222s 1.182s ▄▅▁▄▄
Warm (Listen) 507ms 508ms ▁▁▁▁▁
Warm (Ready in log) 471ms 473ms ▁▁▁▁▁
Warm (First Request) 336ms 337ms ▂▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ▁▁▁█▁
Cold (Ready in log) 435ms 435ms ▃▃▁█▅
Cold (First Request) 1.745s 1.757s ▂▂▁█▃
Warm (Listen) 456ms 457ms ▁▁▁█▁
Warm (Ready in log) 436ms 434ms ▃▃▁█▄
Warm (First Request) 1.752s 1.766s ▂▂▁█▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.190s 4.173s ▁▁▂▁▁
Cached Build 4.169s 4.217s ▁▁▂▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.734s 13.745s ▁▁▁█▂
Cached Build 13.793s 13.855s ▁▁▁█▂
node_modules Size 472 MB 472 MB █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **437 kB** → **437 kB** ✅ -2 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 765 B 761 B
Total 765 B 761 B ✅ -4 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 448 B 451 B
Total 448 B 451 B ⚠️ +3 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 57 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 256 B 254 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.49 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 57.7 kB -
Total 230 kB 231 kB ⚠️ +636 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.49 kB 2.49 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 249 kB 250 kB
Total 375 kB 376 kB ⚠️ +392 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 614 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 33.3 kB 33.2 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.9 kB 34.8 kB ✅ -123 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 733 B 735 B
Total 733 B 735 B ⚠️ +2 B
Build Cache
Canary PR Change
0.pack gzip 3.84 MB 3.85 MB 🔴 +9.02 kB (+0%)
index.pack gzip 102 kB 104 kB 🔴 +1.9 kB (+2%)
index.pack.old gzip 102 kB 103 kB
Total 4.04 MB 4.05 MB ⚠️ +11.8 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 316 kB 316 kB
app-page-exp..prod.js gzip 168 kB 168 kB
app-page-tur...dev.js gzip 315 kB 315 kB
app-page-tur..prod.js gzip 167 kB 167 kB
app-page-tur...dev.js gzip 312 kB 312 kB
app-page-tur..prod.js gzip 166 kB 166 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 166 kB 166 kB
app-route-ex...dev.js gzip 70.5 kB 70.5 kB
app-route-ex..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.5 kB 70.5 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.1 kB 70.1 kB
app-route-tu..prod.js gzip 48.8 kB 48.8 kB
app-route.ru...dev.js gzip 70.1 kB 70.1 kB
app-route.ru..prod.js gzip 48.8 kB 48.8 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB
pages-turbo....dev.js gzip 52.5 kB 52.5 kB
pages-turbo...prod.js gzip 39.4 kB 39.4 kB
pages.runtim...dev.js gzip 52.5 kB 52.5 kB
pages.runtim..prod.js gzip 39.4 kB 39.4 kB
server.runti..prod.js gzip 62.7 kB 62.7 kB
Total 2.8 MB 2.8 MB ⚠️ +2 B

@lukesandberg lukesandberg merged commit 1486592 into canary Feb 12, 2026
165 checks passed

Copy link
Copy Markdown
Contributor Author

Merge activity

@lukesandberg lukesandberg deleted the longer_vc branch February 12, 2026 17:52
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants