Skip to content

Turbopack: Store task error as pointer to the source error#89293

Merged
sokra merged 6 commits into
canaryfrom
sokra/refactor-error-storage
Feb 12, 2026
Merged

Turbopack: Store task error as pointer to the source error#89293
sokra merged 6 commits into
canaryfrom
sokra/refactor-error-storage

Conversation

@sokra

@sokra sokra commented Jan 30, 2026

Copy link
Copy Markdown
Member

Store task error as pointer to the source error

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 30, 2026

sokra commented Jan 30, 2026

Copy link
Copy Markdown
Member Author

@codspeed-hq

codspeed-hq Bot commented Jan 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing sokra/refactor-error-storage (c2df444) with canary (dc35817)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot

nextjs-bot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Stats from current PR

🟢 1 improvement

Metric Canary PR Change Trend
node_modules Size 467 MB 467 MB 🟢 233 kB (0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ▁▁▁▁▁
Cold (Ready in log) 441ms 440ms ▆▅▂▆▅
Cold (First Request) 819ms 804ms ██▁██
Warm (Listen) 456ms 456ms ▁▁▁▁▁
Warm (Ready in log) 440ms 439ms ▁▁▂▁▁
Warm (First Request) 334ms 333ms ▁▅▅▅▅
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 457ms ▁▁▅▁▁
Cold (Ready in log) 437ms 435ms ▃▄▅▃▄
Cold (First Request) 1.759s 1.762s ▂▃▆▁▂
Warm (Listen) 455ms 455ms ▁▁▅▁▁
Warm (Ready in log) 434ms 435ms ▃▃▅▃▃
Warm (First Request) 1.774s 1.765s ▂▃▅▂▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.217s 4.171s ▁▁▃▁▁
Cached Build 4.147s 4.169s ▁▁▃▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.764s 13.744s ▂▃▅▁▁
Cached Build 13.862s 13.866s ▂▃▅▁▁
node_modules Size 467 MB 467 MB 🟢 233 kB (0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **437 kB** → **437 kB** ⚠️ +146 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 761 B 759 B
Total 761 B 759 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 452 B 452 B
Total 452 B 452 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 57 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 256 B 253 B 🟢 3 B (-1%)
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.49 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 57.6 kB -
Total 230 kB 231 kB ⚠️ +592 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.49 kB 2.49 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 249 kB 249 kB
Total 375 kB 376 kB ⚠️ +165 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 615 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 33.3 kB 33.2 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.9 kB 34.8 kB ✅ -57 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 733 B 735 B
Total 733 B 735 B ⚠️ +2 B
Build Cache
Canary PR Change
0.pack gzip 3.84 MB 3.85 MB 🔴 +11.8 kB (+0%)
index.pack gzip 104 kB 104 kB
index.pack.old gzip 102 kB 104 kB 🔴 +2.08 kB (+2%)
Total 4.04 MB 4.06 MB ⚠️ +14.2 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 316 kB 315 kB
app-page-exp..prod.js gzip 168 kB 167 kB
app-page-tur...dev.js gzip 315 kB 315 kB
app-page-tur..prod.js gzip 167 kB 167 kB
app-page-tur...dev.js gzip 312 kB 312 kB
app-page-tur..prod.js gzip 166 kB 166 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 166 kB 166 kB
app-route-ex...dev.js gzip 70.5 kB 70.5 kB
app-route-ex..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.5 kB 70.5 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.1 kB 70.1 kB
app-route-tu..prod.js gzip 48.8 kB 48.8 kB
app-route.ru...dev.js gzip 70.1 kB 70.1 kB
app-route.ru..prod.js gzip 48.8 kB 48.7 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.1 kB
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB
pages-turbo....dev.js gzip 52.5 kB 52.5 kB
pages-turbo...prod.js gzip 39.4 kB 39.4 kB
pages.runtim...dev.js gzip 52.5 kB 52.5 kB
pages.runtim..prod.js gzip 39.4 kB 39.3 kB
server.runti..prod.js gzip 62.7 kB 62.7 kB
Total 2.8 MB 2.8 MB ✅ -1.45 kB
📝 Changed Files (24 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • pages-api-tu..ntime.dev.js
  • pages-api-tu..time.prod.js
  • pages-api.runtime.dev.js
  • pages-api.ru..time.prod.js
  • ... and 4 more
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js

Diff too large to display

app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

pages-api-tu..ntime.dev.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

@sokra sokra force-pushed the sokra/refactor-error-storage branch from 1d0d04e to 93c28a2 Compare January 30, 2026 15:26
@sokra sokra force-pushed the sokra/pretty-print-error branch from 5f0df7a to 1332f0e Compare January 30, 2026 15:26
@nextjs-bot

nextjs-bot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

@sokra sokra force-pushed the sokra/pretty-print-error branch 2 times, most recently from 07a5442 to 062bfa0 Compare January 30, 2026 17:59
@sokra sokra force-pushed the sokra/refactor-error-storage branch from 93c28a2 to bb16933 Compare January 30, 2026 17:59
@graphite-app graphite-app Bot changed the base branch from sokra/pretty-print-error to graphite-base/89293 January 31, 2026 00:29
@sokra sokra changed the title fixup! add test case for error display Turbopack: Store task error as pointer to the source error Feb 2, 2026
@sokra sokra force-pushed the sokra/refactor-error-storage branch from bb16933 to bcaefd3 Compare February 3, 2026 11:41
@sokra sokra force-pushed the graphite-base/89293 branch from 062bfa0 to 7437fed Compare February 3, 2026 11:41
@sokra sokra changed the base branch from graphite-base/89293 to canary February 3, 2026 11:42
@sokra sokra force-pushed the sokra/refactor-error-storage branch from bcaefd3 to 923d041 Compare February 9, 2026 12:28
@sokra sokra marked this pull request as ready for review February 9, 2026 12:30
@sokra sokra requested a review from lukesandberg February 9, 2026 12:30
@sokra sokra force-pushed the sokra/refactor-error-storage branch from 923d041 to b6cd9ff Compare February 10, 2026 07:37
@sokra sokra requested a review from bgw February 10, 2026 20:26

@lukesandberg lukesandberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pretty cool! nice work

Comment thread turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
Comment thread turbopack/crates/turbo-tasks-backend/src/backend/mod.rs Outdated
@sokra sokra merged commit d41c50b into canary Feb 12, 2026
293 of 295 checks passed

sokra commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

Merge activity

@sokra sokra deleted the sokra/refactor-error-storage branch February 12, 2026 05:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants