Conversation
nextjs-bot
added
created-by: Next.js team
Contributor
|
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @huozhi: |
mischnic
approved these changes
Jan 23, 2026
Collaborator
Stats from current PR🟢 1 improvement
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **432 kB** → **432 kB** ✅ -32 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (24 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsDiff too large to display app-page-exp..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsDiff too large to display app-page-tur..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsDiff too large to display app-page-tur..time.prod.jsDiff too large to display app-page.runtime.dev.jsDiff too large to display app-page.runtime.prod.jsDiff too large to display app-route-ex..ntime.dev.jsDiff too large to display app-route-ex..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route.runtime.dev.jsDiff too large to display app-route.ru..time.prod.jsDiff too large to display pages-api-tu..ntime.dev.jsDiff too large to display pages-api-tu..time.prod.jsDiff too large to display pages-api.runtime.dev.jsDiff too large to display pages-api.ru..time.prod.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages-turbo...time.prod.jsDiff too large to display pages.runtime.dev.jsDiff too large to display pages.runtime.prod.jsDiff too large to display |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| config.deploymentId || process.env.NEXT_DEPLOYMENT_ID | ||
| ) | ||
| const staticEnv = getStaticEnv(config, deploymentId) | ||
| const staticEnv = getStaticEnv(config, config.deploymentId) |
Contributor
There was a problem hiding this comment.
Suggested change
| const staticEnv = getStaticEnv(config, config.deploymentId) | |
| const staticEnv = getStaticEnv(config, config.deploymentId || '') |
TypeScript type error: config.deploymentId (string | undefined) passed to getStaticEnv which expects deploymentId: string parameter
| dev: false, | ||
| deploymentId: evaluateDeploymentId(config.deploymentId), | ||
| runtimeServerDeploymentId: config.experimental.runtimeServerDeploymentId, | ||
| deploymentId: config.deploymentId, |
Contributor
There was a problem hiding this comment.
Suggested change
| deploymentId: config.deploymentId, | |
| deploymentId: config.deploymentId || '', |
TypeScript type error: TurbopackManifestLoader expects deploymentId: string, but config.deploymentId is string | undefined
| worker.exportPages({ | ||
| buildId, | ||
| deploymentId: evaluateDeploymentId(nextConfig.deploymentId) || '', | ||
| deploymentId: nextConfig.deploymentId, |
Contributor
There was a problem hiding this comment.
Suggested change
| deploymentId: nextConfig.deploymentId, | |
| deploymentId: nextConfig.deploymentId || '', |
Missing null coalescing operator causes type error: deploymentId is passed as nextConfig.deploymentId (type string | undefined) to a function expecting string
| deploymentId: evaluateDeploymentId(nextConfig.deploymentId), | ||
| runtimeServerDeploymentId: | ||
| nextConfig.experimental.runtimeServerDeploymentId, | ||
| deploymentId: nextConfig.deploymentId, |
Contributor
There was a problem hiding this comment.
Suggested change
| deploymentId: nextConfig.deploymentId, | |
| deploymentId: nextConfig.deploymentId || '', |
TypeScript type error: TurbopackManifestLoader expects deploymentId: string, but nextConfig.deploymentId is string | undefined
| // need to populate in normal runtime env | ||
| if (isCompileMode || isGenerateMode) { | ||
| populateStaticEnv(config, config.deploymentId || '') | ||
| populateStaticEnv(config, config.deploymentId) |
Contributor
There was a problem hiding this comment.
Suggested change
| populateStaticEnv(config, config.deploymentId) | |
| populateStaticEnv(config, config.deploymentId || '') |
TypeScript type error: populateStaticEnv function expects deploymentId: string parameter, but config.deploymentId is string | undefined
| buildId, | ||
| locales: config.i18n?.locales, | ||
| deploymentId: evaluateDeploymentId(config.deploymentId), | ||
| deploymentId: config.deploymentId, |
Contributor
There was a problem hiding this comment.
Suggested change
| deploymentId: config.deploymentId, | |
| deploymentId: config.deploymentId || '', |
TypeScript type error: writeClientSsgManifest requires deploymentId: string parameter, but config.deploymentId is string | undefined causing type mismatch
| buildId, | ||
| dev, | ||
| deploymentId: evaluateDeploymentId(config.deploymentId), | ||
| deploymentId: config.deploymentId, |
Contributor
There was a problem hiding this comment.
Suggested change
| deploymentId: config.deploymentId, | |
| deploymentId: config.deploymentId || '', |
TypeScript type error: BuildManifestPlugin expects deploymentId: string but config.deploymentId is string | undefined, causing potential type incompatibility
eps1lon
deleted the
revert-88496-revert-88449-revert-88012-brooke/addAutomaticDeploymentId
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #88496
This is broken according to @mischnic. We can try to reland after we get deployment tests running. They've been broken for a while and we haven't synced for too long now.