Skip to content

[devtool] bump base-ui to 1.0.0-beta.2 #82206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,7 @@
"[email protected]": "patches/[email protected]",
"@ampproject/[email protected]": "patches/@[email protected]",
"@types/[email protected]": "patches/@[email protected]",
"[email protected]": "patches/[email protected]",
"@base-ui-components/[email protected]": "patches/@[email protected]"
"[email protected]": "patches/[email protected]"
}
}
}
2 changes: 1 addition & 1 deletion packages/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"@babel/runtime": "7.27.0",
"@babel/traverse": "7.27.0",
"@babel/types": "7.27.0",
"@base-ui-components/react": "1.0.0-beta.1",
"@base-ui-components/react": "1.0.0-beta.2",
"@capsizecss/metrics": "3.4.0",
"@edge-runtime/cookies": "6.0.0",
"@edge-runtime/ponyfill": "4.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export function SegmentBoundaryTrigger({
const portalNode = ownerDocument.querySelector('nextjs-portal')!
return portalNode.shadowRoot! as ShadowRoot
})
const shadowRootRef = useRef<ShadowRoot>(shadowRoot)
const triggerRef = useRef<HTMLButtonElement>(null)
const popupRef = useRef<HTMLDivElement>(null)

Expand Down Expand Up @@ -164,8 +163,7 @@ export function SegmentBoundaryTrigger({
disabled={!hasBoundary}
/>

{/* @ts-expect-error remove this expect-error once shadowRoot is supported as container */}
<Menu.Portal container={shadowRootRef}>
<Menu.Portal container={shadowRoot}>
<Menu.Positioner
className="segment-boundary-dropdown-positioner"
side="bottom"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { forwardRef, useRef, useState } from 'react'
import { forwardRef, useState } from 'react'
import { Tooltip as BaseTooltip } from '@base-ui-components/react/tooltip'
import { cx } from '../../utils/cx'
import './tooltip.css'
Expand Down Expand Up @@ -31,7 +31,6 @@ export const Tooltip = forwardRef<HTMLDivElement, TooltipProps>(
const portalNode = ownerDocument.querySelector('nextjs-portal')!
return portalNode.shadowRoot! as ShadowRoot
})
const shadowRootRef = useRef<ShadowRoot>(shadowRoot)
if (!title) {
return children
}
Expand All @@ -45,9 +44,7 @@ export const Tooltip = forwardRef<HTMLDivElement, TooltipProps>(
}}
/>

{/* x-ref: https://github.com/mui/base-ui/issues/2224 */}
{/* @ts-expect-error remove this expect-error once shadowRoot is supported as container */}
<BaseTooltip.Portal container={shadowRootRef}>
<BaseTooltip.Portal container={shadowRoot}>
<BaseTooltip.Positioner
side={direction}
sideOffset={offset + arrowSize}
Expand Down
59 changes: 39 additions & 20 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading