Skip to content

GTM dataLayer parameter should take an object, not an array of strings #66339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2024
Merged

GTM dataLayer parameter should take an object, not an array of strings #66339

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e87d9e6
GTM dataLayer parameter should take an object, not an array of strings
marlier May 29, 2024
1d60659
Merge branch 'canary' into third-party-gtm-accept-object
marlier May 29, 2024
16687b9
update docs to give correct parameter type
marlier May 29, 2024
5453b13
Merge branch 'canary' into third-party-gtm-accept-object
samcx Jul 12, 2024
018d77a
Merge branch 'canary' into third-party-gtm-accept-object
samcx Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/third-parties/src/types/google.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ declare global {
}
}

type JSONValue =
| string
| number
| boolean
| JSONValue[]
| { [key: string]: JSONValue }

export type GTMParams = {
gtmId: string
dataLayer?: string[]
dataLayer?: { [key: string]: JSONValue }
dataLayerName?: string
auth?: string
preview?: string
Expand Down
Loading