fix(core): preserve runtime fields in validate() with passthrough#255
Open
tmchow wants to merge 1 commit intovercel-labs:mainfrom
Open
fix(core): preserve runtime fields in validate() with passthrough#255tmchow wants to merge 1 commit intovercel-labs:mainfrom
tmchow wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Zod's default parse mode strips unknown keys. Element runtime fields (on, repeat, watch, state) aren't in the validation schema, so they were silently removed. Use .passthrough() on object and record schemas so unknown keys survive validation while known fields are still checked. Fixes vercel-labs#222
Contributor
|
@tmchow is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catalog.validate()silently stripson,repeat,watch, andstatefrom element objects because Zod's default parse mode removes unknown keys.Changes
packages/core/src/schema.ts: Added.passthrough()to object schemas inbuildZodType()so unknown keys survive validation. Also applied to record schemas when their values are objects. Known fields are still validated; unknown fields (runtime fields likeon,repeat,watch,state) pass through unchanged.Testing
All 892 existing tests pass.
pnpm type-checkpasses.Fixes #222
This contribution was developed with AI assistance (Codex).