Updates for fxamacker/cbor 2.9.0 release #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibmat
requested review from
OR13,
SimonFrost-Arm,
SteveLasker,
henkbirkholz,
qmuntal,
roywill,
setrofim,
shizhMSFT,
thomas-fossati and
yogeshbdeshpande
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 91.23% 92.33% +1.10%
==========================================
Files 13 13
Lines 2133 1723 -410
==========================================
- Hits 1946 1591 -355
+ Misses 128 73 -55
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, I see the latest release was a year ago, may it be possible to include this PR in a fresh one? |
OR13
approved these changes
Sep 13, 2025
|
I ran into this one too -- would be great to have this one merged, thank you! |
Contributor
|
@gibmat, can you please resolve the conflicts? |
Signed-off-by: Mathias Gibbens <[email protected]>
gibmat
force-pushed
the
update-cbor-2.9
branch
from
53a220f to
93ffa3b
Compare
SteveLasker
approved these changes
Nov 7, 2025
Contributor
SteveLasker
left a comment
SteveLasker
left a comment
There was a problem hiding this comment.
LGTM
Thanks, @gibmat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of some errors changed with the fxamacker/cbor 2.9.0 release.