Skip to content

Conversation

@shizhMSFT
Copy link
Contributor

Fix #213 for the build failure of the CWT example.

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (92fbe95) to head (babaebc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   92.35%   91.27%   -1.09%     
==========================================
  Files          12       12              
  Lines        1622     2005     +383     
==========================================
+ Hits         1498     1830     +332     
- Misses         68      119      +51     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shizhMSFT shizhMSFT requested a review from Copilot March 17, 2025 09:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses build failures in the CWT example by modifying the example function's name.

  • Renamed the example function from ExampleCWTMessage to Example_cWTMessage to resolve build issues.
Comments suppressed due to low confidence (1)

cwt_test.go:13

  • [nitpick] Consider revisiting the naming convention for Go example functions. The standard approach typically uses CamelCase (e.g., ExampleCWTMessage), so if the change to Example_cWTMessage is required for the build, adding a clarifying comment might help future maintainers.
func Example_cWTMessage() {

@shizhMSFT
Copy link
Contributor Author

Local preview:
image

Copy link
Member

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it is renamed as ExampleCWTClaims? This way the example will be attached to the CWTClaims struct, which is probably more aligned with the original intention.

Signed-off-by: Shiwei Zhang <[email protected]>
@shizhMSFT
Copy link
Contributor Author

@qmuntal That also works. Updated to CWTClaims.

@shizhMSFT
Copy link
Contributor Author

New look:
image

@shizhMSFT shizhMSFT merged commit cfe4231 into veraison:main Mar 18, 2025
4 checks passed
@shizhMSFT shizhMSFT deleted the fix_cwt_example branch March 18, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example failed to build in vscode with go 1.24

3 participants