Skip to content

Conversation

@qmuntal
Copy link
Member

@qmuntal qmuntal commented Aug 18, 2023

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #166 (fbff149) into main (4451940) will increase coverage by 0.22%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   93.82%   94.05%   +0.22%     
==========================================
  Files          11       11              
  Lines        1701     1715      +14     
==========================================
+ Hits         1596     1613      +17     
+ Misses         72       69       -3     
  Partials       33       33              
Files Coverage Δ
cbor.go 87.50% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SteveLasker SteveLasker requested a review from OR13 August 18, 2023 14:41
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for spotting the bug...

@OR13 OR13 self-requested a review August 25, 2023 15:21
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the call today, there was discussion on wanting "some number of additional unit tests" related to marshal and unmarshal.

This is vague, so any number of increases in unit tests would unblock my review.

I am requesting "additional unit tests" at the discretion of the maintainers.

@SteveLasker
Copy link
Contributor

@qmuntal to evaluate what additional tests are required to build confidence to merge.

Signed-off-by: qmuntal <[email protected]>
@qmuntal qmuntal requested a review from OR13 September 26, 2023 07:01
@qmuntal
Copy link
Member Author

qmuntal commented Sep 26, 2023

@qmuntal to evaluate what additional tests are required to build confidence to merge.

I've gone through the test suite of other COSE libraries, most notably https://github.com/google/coset, and I haven't found any outstanding missing case on our suite. IMO this is ready to merge.

@qmuntal qmuntal merged commit 6e436d2 into main Sep 26, 2023
@qmuntal qmuntal deleted the cborupgrade branch September 26, 2023 14:30
@SteveLasker
Copy link
Contributor

Thanks, @qmuntal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signature.Sign doesn't check for malformed protected data containing extraneous bytes

6 participants