Skip to content

Top-level code environment updates#3

Open
soltanoff wants to merge 8 commits intoventhur:masterfrom
soltanoff:master
Open

Top-level code environment updates#3
soltanoff wants to merge 8 commits intoventhur:masterfrom
soltanoff:master

Conversation

@soltanoff
Copy link
Copy Markdown
Contributor

@soltanoff soltanoff commented Feb 5, 2023

  • wxPython 4.2.0 compatibility (wxPython packages updates: v4.2.0 #4)
  • Fixed deprecation warning (wxPython packages updates: v4.2.0 #4)
  • Fixed top-level code environment
  • Modernized setup.py: updated and fixed installation meta
  • Modernized version control: rename version.py -> vertion.txt
  • Added requirements.txt
  • Added .flake8 and fixed the code
  • Added .editorconfig
  • Updated application resource

DE7AAFFA-2BF9-463E-9733-413F6BDAE03E

@soltanoff
Copy link
Copy Markdown
Contributor Author

@venthur, hi!
Might you review this PR?

Thank you!

@venthur
Copy link
Copy Markdown
Owner

venthur commented Feb 5, 2023

Hi,

thank you very much for the PR! Can you please separate the wxpython specific changes from the other ones? I.e. there are a lot of unrelated changes in this PR, which should go into separate ones so I can review and merge them individually.

Thank you!

@soltanoff soltanoff changed the title wxPython 4.2.0 compatibility Top-level code environment updates Feb 6, 2023
@soltanoff
Copy link
Copy Markdown
Contributor Author

soltanoff commented Feb 6, 2023

Hi,

sure! PR is ready: #4

Thank you!

@soltanoff
Copy link
Copy Markdown
Contributor Author

I’ll rebase it soon. Thank you, @venthur!

@soltanoff soltanoff reopened this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants