Custom JSON Coders for Postgres Data Coders #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der to PostgresEncoder
…ct call in PostgresConnectionSource.makeConnection method
…Database.encoder and .decoder properties
This results in an erased private _PostgreSQLRow struct instance that handles all the confrmance
tanner0101
reviewed
Dec 10, 2019
…n.test(on:) method
This reverts commit 0fa2d80.
|
@tanner0101 Ready for another review. I've added a test case for the custom JSON coding to the FluentPostgresDriver, since that was the easiest place to put it. |
tanner0101
reviewed
Dec 11, 2019
|
@tanner0101 Both this PR and vapor/fluent-postgres-driver#129 are ready for another review. |
tanner0101
previously approved these changes
Dec 11, 2019
Co-Authored-By: Tanner <[email protected]>
tanner0101
previously approved these changes
Dec 11, 2019
tanner0101
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on vapor/postgres-nio#59