Skip to content

Update PostgresError's DatabaseError conformance for new PostgresNIO behavior #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 7, 2023

This makes DatabaseError.isSyntaxError and .isConstraintFailure work again.

@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels May 7, 2023
@gwynne gwynne requested a review from 0xTim May 7, 2023 04:21
@codecov-commenter
Copy link

Codecov Report

Merging #208 (ec340a6) into main (c7cd020) will decrease coverage by 0.75%.
The diff coverage is 23.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   77.29%   76.55%   -0.75%     
==========================================
  Files           7        7              
  Lines         414      354      -60     
==========================================
- Hits          320      271      -49     
+ Misses         94       83      -11     
Impacted Files Coverage Δ
.../FluentPostgresDriver/PostgresError+Database.swift 76.92% <23.80%> (-9.19%) ⬇️

... and 6 files with indirect coverage changes

@gwynne gwynne merged commit c7e3976 into main May 7, 2023
@gwynne gwynne deleted the fix-database-error-test branch May 7, 2023 10:23
@VaporBot
Copy link

VaporBot commented May 7, 2023

These changes are now available in 2.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants