Skip to content

Secondary environment variable name #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathanfallet merged 1 commit into from
Jul 31, 2022
Merged

Secondary environment variable name #49

nathanfallet merged 1 commit into from
Jul 31, 2022

Conversation

@nathanfallet
Copy link
Member

@nathanfallet nathanfallet commented Jun 19, 2022

Fixes #30

@Andrewangeta
Copy link
Member

Andrewangeta commented Jun 19, 2022

LGTM
Also @nathanfallet In the process of converting the library to async await so the entire auth process is being reworked in that branch. #44
I'd take a look into upgrading here as soon as we can. I've been a little behind but if your specific API is being used I'd go ahead and use that branch or the latest commit hash and pin to that.

@nathanfallet
Copy link
Member Author

nathanfallet commented Jun 19, 2022

@Andrewangeta Okay so I keep the branch here unmerged. In case you want to merge it (even in your own branch) feel free to do what you need.

@nathanfallet nathanfallet merged commit 9e37456 into master Jul 31, 2022
@nathanfallet nathanfallet deleted the env branch July 31, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andrewangeta Andrewangeta Andrewangeta approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change environment variable name

2 participants

@nathanfallet @Andrewangeta