Skip to content

Media download bug #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eob wants to merge 2 commits into from
Closed

Media download bug #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fb1212
Change request URL and query params
eob May 19, 2021
a7b6746
Fix forwrd
eob May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Storage/Sources/API/StorageObjectAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ extension StorageObjectAPI {
public final class GoogleCloudStorageObjectAPI: StorageObjectAPI {
let endpoint = "https://www.googleapis.com/storage/v1/b"
let uploadEndpoint = "https://www.googleapis.com/upload/storage/v1/b"
let mediaDownloadEndpoint = "https://storage.googleapis.com"
let request: GoogleCloudStorageRequest

init(request: GoogleCloudStorageRequest) {
Expand Down Expand Up @@ -382,10 +383,7 @@ public final class GoogleCloudStorageObjectAPI: StorageObjectAPI {
public func getMedia(bucket: String, object: String, range: ClosedRange<Int>?, queryParameters: [String: String]?) -> EventLoopFuture<GoogleCloudStorgeDataResponse> {
var queryParams = ""
if var queryParameters = queryParameters {
queryParameters["alt"] = "media"
queryParams = queryParameters.queryParameters
} else {
queryParams = "alt=media"
}

var headers: HTTPHeaders = [:]
Expand All @@ -394,7 +392,7 @@ public final class GoogleCloudStorageObjectAPI: StorageObjectAPI {
headers.add(name: "Range", value: "bytes=\(range.lowerBound)-\(range.upperBound)")
}

return request.send(method: .GET, headers: headers, path: "\(endpoint)/\(bucket)/o/\(object)", query: queryParams)
return request.send(method: .GET, headers: headers, path: "\(mediaDownloadEndpoint)/\(bucket)/\(object)", query: queryParams)
}

public func createSimpleUpload(bucket: String,
Expand Down