Implements GetWalletAccount operation bypassing fistful service
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WWWcool
reviewed
Jul 16, 2025
src/wapi_domain_backend.erl
Outdated
Comment on lines
26
to
27
| _Party = unwrap(object({party_config, #domain_PartyConfigRef{id = PartyID}})), | ||
| {#{<<"id">> => PartyID}, PartyID} |
There was a problem hiding this comment.
а почему решил поправить?
There was a problem hiding this comment.
Так там ид нету внутри, а раньше был. Так фактически проверяется что пати существует а возвращается кортеж который дальше используется, например, для формирования контекста для запроса в Баунсер.
| case wapi_wallet_backend:get_account(WalletID, Context) of | ||
| {ok, WalletAccount} -> wapi_handler_utils:reply_ok(200, WalletAccount); | ||
| {error, {wallet, notfound}} -> wapi_handler_utils:reply_ok(404) | ||
| end |
There was a problem hiding this comment.
надо бы еще глянуть что контекст для кошелька норм собирается - там же почти тоже самое - нужно вычитать кошелек и ео отмаршалить в баунсер контекст - не помню как я это сделал и делал ли
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.