Skip to content

Hack to fix Gemini CLI build. #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacob314 wants to merge 1 commit into from
+2 −4
Closed

Hack to fix Gemini CLI build. #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"@sinonjs/fake-timers": "^14.0.0",
"@types/ms": "^2.1.0",
"@types/node": "^22.15.24",
"@types/react": "^19.1.5",
"@types/react": "^19.1.8",
"@types/react-reconciler": "^0.32.0",
"@types/signal-exit": "^3.0.0",
"@types/sinon": "^17.0.3",
Expand Down
4 changes: 1 addition & 3 deletions src/ink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
this.fullStaticOutput = '';

// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
this.container = reconciler.createContainer(
this.container = (reconciler as any).createContainer(

Check failure on line 98 in src/ink.tsx

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unsafe call of an `any` typed value.
this.rootNode,
LegacyRoot,
null,
Expand All @@ -104,8 +104,6 @@
'id',
() => {},
() => {},
// @ts-expect-error the types for `react-reconciler` are not up to date with the library.
// See https://github.com/facebook/react/blob/c0464aedb16b1c970d717651bba8d1c66c578729/packages/react-reconciler/src/ReactFiberReconciler.js#L236-L259
() => {},
() => {},
null,
Expand Down
Loading