React 19 Support #719
Merged
React 19 Support #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
|
@msmps Thanks for doing the work on this 🙏 |
Collaborator
|
Moved concurrent discussion here: #720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time over the weekend working on adding support for React 19. I’ve successfully got it working, but opted to stick with the legacy rendering mode rather than enabling concurrent mode for now.
This means that React will continue to render updates synchronously, maintaining the existing behaviour.
At this point, all tests are passing.
Additionally, the types provided by DefinitelyTyped are not yet up to date with the latest version of the React reconciler, so I’ve added a few
@ts-expect-errorcomments to work around that for the time being.I’ve published a testing version of this fork as:
Concurrent Mode
I did experiment with enabling concurrent mode and got it working, but the test suite revealed several issues:
act()and converted to async.act().unmount()is/was firing multiple times, potentially causing these warnings.It felt like concurrent mode would require a more involved refactor. I’d suggest we consider this as a fast follow-up once React 19 legacy support is merged.
I’ve pushed a separate branch with the concurrent mode changes if anyone wants to explore or contribute to that effort.
Addresses: #688 #656